You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As per lgtm.com's warning, it looks like byte-padding in method
private final String _decodeLongUnicodeName(int[] quads, int byteLen, int quadLen) {
is slightly wrong, as it assumes lastQuadBytes value to be between [1, 4], but it is actually [0, 3].
Looks like this might potentially lead to collision between 2 long strings with lengths divisible by 4, where only some of last 4 characters differ. Coming up with a test may be challenging.
The text was updated successfully, but these errors were encountered:
Looking at this, I do NOT think this actually resulted in actual bug, only (very) slightly suboptimal handling. Will do it nevertheless, but no reproduction since there isn't actual issue as far as I can reason.
As per lgtm.com's warning, it looks like byte-padding in method
is slightly wrong, as it assumes
lastQuadBytes
value to be between [1, 4], but it is actually [0, 3].Looks like this might potentially lead to collision between 2 long strings with lengths divisible by 4, where only some of last 4 characters differ. Coming up with a test may be challenging.
The text was updated successfully, but these errors were encountered: