Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(routes/pdf/txt): remove listEncodingOptions qs param #1354

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

Fdawgs
Copy link
Owner

@Fdawgs Fdawgs commented Mar 23, 2023

Barely worked and when it did it exposed underlying server details (the charsets).
Not a breaking change as it was broken to begin with!

#1353 will fill the space of listing supported encodings.

@Fdawgs Fdawgs self-assigned this Mar 23, 2023
@coveralls
Copy link

coveralls commented Mar 23, 2023

Pull Request Test Coverage Report for Build 4508994842

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 4508977435: 0.0%
Covered Lines: 1118
Relevant Lines: 1118

💛 - Coveralls

@Fdawgs Fdawgs force-pushed the fix/routes-pdf-txt-encoding branch from 72591cd to 43d495a Compare March 24, 2023 07:57
@Fdawgs Fdawgs merged commit 3eb0d71 into main Mar 24, 2023
@Fdawgs Fdawgs deleted the fix/routes-pdf-txt-encoding branch March 24, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants