Remove code setting the content of the overflow button to "More" on A…

…pplyTemplate(). Also removed the entry for the "More" string in the ResourceHelper logic and in the default NavigationView resource file.
Felix-Dev · Aug 7, 2020 · f8da599 · f8da599
1 parent a852c6d
commit f8da599
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 6 deletions.
diff --git a/dev/NavigationView/NavigationView.cpp b/dev/NavigationView/NavigationView.cpp
@@ -470,7 +470,6 @@ void NavigationView::OnApplyTemplate()
     {
         m_topNavOverflowButton.set(topNavOverflowButton);
         winrt::AutomationProperties::SetName(topNavOverflowButton, ResourceAccessor::GetLocalizedStringResource(SR_NavigationOverflowButtonName));
-        topNavOverflowButton.Content(box_value(ResourceAccessor::GetLocalizedStringResource(SR_NavigationOverflowButtonText)));
         auto visual = winrt::ElementCompositionPreview::GetElementVisual(topNavOverflowButton);
         CreateAndAttachHeaderAnimation(visual);
 

diff --git a/dev/NavigationView/Strings/en-us/Resources.resw b/dev/NavigationView/Strings/en-us/Resources.resw
@@ -153,10 +153,6 @@
     <value>More Button</value>
     <comment>Automation name for the nav view more button when panel is on top</comment>
   </data>
-  <data name="NavigationOverflowButtonText" xml:space="preserve">
-    <value>More</value>
-    <comment>Text for the nav view more button when panel is on top</comment>
-  </data>
   <data name="NavigationOverflowButtonToolTip" xml:space="preserve">
     <value>See more</value>
     <comment>ToolTip caption for the nav view more button when panel is on top</comment>

diff --git a/dev/ResourceHelper/ResourceAccessor.h b/dev/ResourceHelper/ResourceAccessor.h
@@ -45,7 +45,6 @@ class ResourceAccessor sealed
 #define SR_NavigationBackButtonToolTip L"NavigationBackButtonToolTip"
 #define SR_NavigationCloseButtonName L"NavigationCloseButtonName"
 #define SR_NavigationOverflowButtonName L"NavigationOverflowButtonName"
-#define SR_NavigationOverflowButtonText L"NavigationOverflowButtonText"
 #define SR_NavigationOverflowButtonToolTip L"NavigationOverflowButtonToolTip"
 #define SR_SettingsButtonName L"SettingsButtonName"
 #define SR_NavigationViewSearchButtonName L"NavigationViewSearchButtonName"