Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing CRLF epilogue #2

Merged
merged 2 commits into from
Feb 1, 2022
Merged

Conversation

MMP0
Copy link
Contributor

@MMP0 MMP0 commented Feb 1, 2022

Missing the extra CRLF that marks the end of the outer headers.

multipart-body := [preamble CRLF]
                  dash-boundary CRLF
                  body-part *encapsulation
                  close-delimiter
                  [CRLF epilogue]

See: https://datatracker.ietf.org/doc/html/rfc2046#page-22

If the server is using a strict parser, the request will fail. (such as Google)

@FelixHerrmann
Copy link
Owner

Hi, you're totally right, thanks for finding this! We actually used it for sending Google request but it has never failed for us...
I will merge this now, just have to fix the Unit tests!

@FelixHerrmann FelixHerrmann merged commit 19f4e7a into FelixHerrmann:master Feb 1, 2022
@MMP0 MMP0 deleted the patch-1 branch February 2, 2022 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants