-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors when running more than one instance of wl-present #51
Comments
I fixed the underlying issue in pipectl (released as v0.5.1), but |
This fixes wl-mirror staying open when its input closes in stream mode. Previously wl-mirror also hanged in this case as it attempted to read stdin in response to the EPOLLHUP event. Partial fix for #51.
Partially fixed in 100718b. This, together with
|
Fixed in df1b3ab. |
Support for multiple instances implemented in 98f9aab. |
Documentation for multiple instances now also done. |
Thank you for the quick fix! Thinking about this I also considered the scenario of wanting to control multiple instances with a single command. It's not something I expect to need, but it might be useful for
Implementing this would be a bit more complicated, since it requires one-to-many communication. One approach which might work is to use the new Would you be interested in such a feature? |
I think such features are better off implemented as downstream scripts as they are quite niche. |
Also: released in v0.17.0 |
It seems that
wl-present
is designed to be used with only a single mirror running. Being able to control multiple mirrors at the same time would be nice, but this can also be done in a more manual way usingwl-mirror
.The issue I encountered is that
wl-present
happily starts up more than one instance, but then fails. How it fails depends on whetherpipectl-shim
orpipectl
is used.pipectl-shim
is used, two mirror instances will run, but only the second one receives subsequent commands (because the pipe opened by the first instance is deleted and recreated).pipectl
is used, thepipectl
process fails when it detects that the pipe already exists. During cleanup (in thepipectl
process), the existing pipe is deleted (which might also be undesirable behavior). Thewl-mirror
process then seems to be busy waiting in the event loop. The output is not mirrored and the window is unresponsive.Ideally, controlling multiple mirrors at the same time could be supported, but this would probably make the application design significantly more complicated. Alternatively, it would be a nice improvement if no second mirror can be started using
wl-present
if one is already active (e.g. by checking if the named pipe exists).The text was updated successfully, but these errors were encountered: