Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed behaviour #59

Open
2 tasks
dimalvovs opened this issue Nov 8, 2023 · 0 comments
Open
2 tasks

Seed behaviour #59

dimalvovs opened this issue Nov 8, 2023 · 0 comments
Labels
bug Something isn't working core

Comments

@dimalvovs
Copy link
Contributor

dimalvovs commented Nov 8, 2023

Behaviour of the program with a set seed parameter in unexpected and needs to be aligned with requirements/common practice. There are two different unexpected behaviour patterns:

  1. Standard pycogaps current behaviour: all runs without a seed yield the same result, which inter alia numerically corresponds to seed=0, which means the seed it set somewhere even if it's not provided by the user. Expected behaviour: runs without setting a seed differ. To reproduce: run pycogaps on modSim toy data without setting a seed and observe the resulting .obs and .var matrices are kept exactly equal. Run with seed:0 to obtain exactly same result. run with seed:42 to obtain a different result.
  2. Distributed pycogaps current behaviour: runs with the same seed yield different results. Expected behaviour: runs with the same seed produce exactly the same result. To reproduce: add setParams(params, {'distributed':'genome-wide', 'seed':42}) and observe that results are different each time. Removing the seed from parameters does not affect the result randomness.
  • standard run: unfix results if no seed provided
  • distributed: fix results if seed provided
@dimalvovs dimalvovs added the bug Something isn't working label Nov 8, 2023
@dimalvovs dimalvovs added the core label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core
Projects
None yet
Development

No branches or pull requests

1 participant