Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launcherArguments for secondaryLaunchers #55

Closed
vhkrausser opened this issue Feb 9, 2017 · 2 comments
Closed

launcherArguments for secondaryLaunchers #55

vhkrausser opened this issue Feb 9, 2017 · 2 comments

Comments

@vhkrausser
Copy link

If we specify a secundary launcher for the build with custom lauch parameters, all lauchers have the parameters from the latest configuration readed by the plugin.

This happens (I belive ) at line 212 of the JfxNativeWorker.

Where we read params.put(StandardBundlerParam.ARGUMENTS.getID(), new ArrayList<>(arguments));

Should be: secondaryLauncherGenerationMap.put(StandardBundlerParam.ARGUMENTS.getID(), new ArrayList<>(arguments));

@FibreFoX
Copy link
Owner

FibreFoX commented Feb 9, 2017

Indeed, thanks for catching this 👍

Btw: this even is inside javafx-maven-plugin

FibreFoX added a commit to FibreFoX/javafx-maven-plugin that referenced this issue Feb 9, 2017
FibreFoX added a commit that referenced this issue Feb 9, 2017
… set

seems like a stupid refactoring mistake
@FibreFoX
Copy link
Owner

FibreFoX commented Feb 9, 2017

This is now fixed :) should take a bit to hit maven-central

@FibreFoX FibreFoX closed this as completed Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants