Update to make compatible with Provenance 1.19 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brashidnia-figure is this PR good to go or is there anything else you'd like me to take a look at? It looks like that test action isn't passing but that seems to have been broken for quite awhile. |
brashidnia-figure
approved these changes
Sep 3, 2024
Ya i think you are good to go. And ya those tests have not been working since we never got a newer version of provenance to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
With the release of Provenance 1.19 the contract fails on ask creation when querying for a marker that uses a non-supported enum (force_transfer)
Solution:
This PR upgrades the dependencies to use v2.3.0 of provwasm std. Tests that call functions that validate addresses were updated to use valid bech32 addresses since this is now a requirement in the mock api.