This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
Implementing zxcvbn instead of stupid rules #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
@open-schnick you wanna push your commits? |
na |
qvalentin
reviewed
Jan 22, 2022
| .then((res) => { | ||
| changeEditMode(); | ||
| // FIXME this does never appear, because we rerender it and this gets lost |
There was a problem hiding this comment.
Alerts should be defined global. Would need a lot more refacotring.
There was a problem hiding this comment.
Y. Dont know why we are not using something like this: https://www.npmjs.com/package/react-notifications
qvalentin
suggested changes
Jan 23, 2022
qvalentin
previously approved these changes
Jan 23, 2022
qvalentin
approved these changes
Jan 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.