Freebsd port improvements #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get_cpu_total(). Rust code expect u64, C code returned unsigned long. These are the same types only on LP64 architectures. Use uint64_t for return type.
Return system error if sysctl(2) failed. Do not pretend that the function is implemented on !x86, return fake 1GHz instead.
|
@FillZpp can you help merging this one? Thanks! |
|
@lwhsu Sure. Have you tested it before? |
|
@FillZpp yes, and I believe @kostikbel has tested this well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly, these commits systematically return error instead of success with meaningless data for OS failures. Also they fix small bugs in the port like type mismatch for non-64bit architectures.