More API Blueprint fixes #2
Conversation
icidasset
force-pushed
the
fix-api-blueprint-format
branch
from
a0baadf to
bb5546d
Compare
| @@ -16,34 +19,49 @@ FORMAT: 1A | |||
| ## {{ route_name }} [{{ route }}] | |||
| {{# description }} | |||
|
|
|||
| description: {{ description }} | |||
| {{ description }} | |||
There was a problem hiding this comment.
Not sure what value this should have... or if it even works.
There was a problem hiding this comment.
Cool, thanks, we just need to add apiblueprint validations in spec suite, and we'll be done.
There was a problem hiding this comment.
Fixed the specs, and added an expectation for the "route explanations". I can't seem to write an expectation for the "method explanations", although it works when I use the gem. Something seems off with the http_methods in the specs for some reason.
| {{# attributes }} | ||
| + {{ name }}{{# example }}: {{ example }}{{/ example }}{{# properties_description }} ({{ properties_description }}){{/ properties_description }}{{# description }} - {{ description }}{{/ description }} |
There was a problem hiding this comment.
example is the RSpec example in this case, which we don't want. I wanted to render the actual value of the param here, but I don't think it's possible without some serious refactoring. I did add the ability to define the "default" though.
Anyhow, if you have an idea how we could get the actual parameter value in here that would be amazing 🙏
Hi 👋
Thanks for fixing the API Blueprint stuff.
Here are some further improvements I made (possibly):
routes and methods (eg.get ...)Does this fix the issue you have with attributes?