Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Angular 13 #494

Merged
merged 40 commits into from
Dec 14, 2021
Merged

Migration to Angular 13 #494

merged 40 commits into from
Dec 14, 2021

Conversation

achilehero
Copy link
Contributor

@achilehero achilehero commented Dec 7, 2021

Hi guys!
I started looking into upgrading the DS to Angular 13. As usual, there is no easy way with these things :)
In this case here, the big change is that @angular/material 13 has dropped tilde imports. So changes like in libs/angular-components/video-thumbnail/src/video-thumbnail.component.scss are working and are fine ~@angular/material changed to @angular/material.
However, we have two use cases, in

@use '~@angular/material/core/style/elevation' with ( $opacity: 0.8 );
and
@use '~@angular/material/core/theming/palette' as matPalette;
where it doesn't work, either with ~ or without it.

While I am further investigating on how to solve it, if anyone has any idea, please shoot!

Copy link
Collaborator

@ttalbot ttalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for upgrading 🙏

You removed ~ from @use statements on @angular/material, I think it's no longer necessary even for other packages.
This can be part of another PR.

angular.json Show resolved Hide resolved
@achilehero
Copy link
Contributor Author

There is an open issue in the nx repo: nrwl/nx#7844. I already tried the suggested changes in the jest.preset.js but it doesn't seem to be working, though. Some other things I found on the topic: thymikee/jest-preset-angular#1090 and thymikee/jest-preset-angular#1149 (which is actually pointing me to the first issue)

@ttalbot ttalbot merged commit 5dce035 into master Dec 14, 2021
@ttalbot ttalbot deleted the feature/angular-13 branch December 14, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants