-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration to Angular 13 #494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for upgrading 🙏
You removed ~ from @use statements on @angular/material, I think it's no longer necessary even for other packages.
This can be part of another PR.
There is an open issue in the nx repo: nrwl/nx#7844. I already tried the suggested changes in the |
…-design-system into feature/angular-13
…-design-system into feature/angular-13
…-design-system into feature/angular-13
…-design-system into feature/angular-13
…-design-system into feature/angular-13
Hi guys!
I started looking into upgrading the DS to Angular 13. As usual, there is no easy way with these things :)
In this case here, the big change is that @angular/material 13 has dropped tilde imports. So changes like in
libs/angular-components/video-thumbnail/src/video-thumbnail.component.scss
are working and are fine~@angular/material
changed to@angular/material
.However, we have two use cases, in
finastra-design-system/themes/angular-theme/lib/core/_core.scss
Line 2 in 30e4d8d
finastra-design-system/themes/angular-theme/lib/core/theming/_palette.scss
Line 4 in 30e4d8d
~
or without it.While I am further investigating on how to solve it, if anyone has any idea, please shoot!