Skip to content
This repository has been archived by the owner on Nov 19, 2018. It is now read-only.

Consider making fine-uploader a peer dependency #35

Closed
rnicholus opened this issue Sep 18, 2016 · 2 comments
Closed

Consider making fine-uploader a peer dependency #35

rnicholus opened this issue Sep 18, 2016 · 2 comments
Milestone

Comments

@rnicholus
Copy link
Member

rnicholus commented Sep 18, 2016

Instead of automatically installing fine-uploader, perhaps it should be a peer dependency. This may make more sense for projects that already install fine-uploader for use elsewhere in their app where react-fine-uploader is not being used. I can see some projects gradually moving their React-based upload widgets over to react-fine-uploader, and they probably would like to avoid having fine-uploader bundled twice. Not sure this is a valid concern yet - needs more exploration.

@rnicholus rnicholus added this to the 0.1.0 milestone Sep 18, 2016
@rnicholus rnicholus changed the title Consider making fine-uploader a peer dependency. Consider making fine-uploader a peer dependency Sep 18, 2016
@rnicholus rnicholus removed this from the 0.1.0 milestone Sep 18, 2016
@rnicholus
Copy link
Member Author

rnicholus commented Mar 27, 2017

nah - not convinced there is any real benefit to making this a peerDependency

@rnicholus rnicholus added this to the 1.0.0-rc2 milestone Apr 1, 2017
@rnicholus
Copy link
Member Author

On second thought, maybe this is a good idea as it will make it easier to ensure only one copy of Fine Uploader exists, and put the responsibility/power on the integrator to choose the specific version of Fine Uploader to use. The wrappers project should be updated in this manner as well.

@rnicholus rnicholus reopened this Apr 1, 2017
rnicholus added a commit to FineUploader/fine-uploader-wrappers that referenced this issue Apr 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant