Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add msg instantiate2 #80

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Feature/add msg instantiate2 #80

merged 2 commits into from
Mar 14, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Feb 24, 2023 •
edited
Loading

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I have added a relevant changelog to CHANGELOG.md.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@jaeseung-bae jaeseung-bae force-pushed the feature/add-msg-instantiate2 branch from 9fb417f to da68e15 Compare February 24, 2023 05:40
@jaeseung-bae jaeseung-bae mentioned this pull request Feb 24, 2023
Closed
3 tasks
@jaeseung-bae jaeseung-bae self-assigned this Feb 24, 2023
@jaeseung-bae jaeseung-bae marked this pull request as ready for review February 24, 2023 05:57
loin3
loin3 reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@loin3 loin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be a function for instantiate2 for amino.
Is it better to add that in another PR?

@jaeseung-bae
Copy link
Contributor Author

Okay, let's do amino in anther PR.

@loin3 loin3 self-requested a review February 24, 2023 08:05
@jaeseung-bae jaeseung-bae force-pushed the feature/add-msg-instantiate2 branch from 0cfe465 to c980f6c Compare March 2, 2023 00:17
@jaeseung-bae jaeseung-bae requested a review from tkxkd0159 March 3, 2023 00:47
@jaeseung-bae jaeseung-bae mentioned this pull request Mar 13, 2023
Closed
@jaeseung-bae jaeseung-bae merged commit bdca8c3 into main Mar 14, 2023
@zemyblue zemyblue mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loin3 loin3 loin3 approved these changes

@dudong2 dudong2 dudong2 approved these changes

@0Tech 0Tech Awaiting requested review from 0Tech

@zemyblue zemyblue Awaiting requested review from zemyblue

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159

Assignees

@jaeseung-bae jaeseung-bae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apply InstantiateContract2 of wasmd
3 participants
@jaeseung-bae @dudong2 @loin3