Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is it appropriate for sig_block_height to be included in the tx_body? #293

Closed
4 tasks
egonspace opened this issue Jul 16, 2021 · 0 comments · Fixed by #344
Closed
4 tasks

Is it appropriate for sig_block_height to be included in the tx_body? #293

egonspace opened this issue Jul 16, 2021 · 0 comments · Fixed by #344
Assignees
@egonspace
Labels
A: improvement Changes in existing functionality
Milestone
CBDC functional r...

Comments

@egonspace
Copy link

egonspace commented Jul 16, 2021 •
edited
Loading

Summary

sig_block_height should be included in tx_body by #265.
But by definition, it would be more appropriate to enter the sign doc.
We need to think about this.

Problem Definition

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@egonspace egonspace added the A: improvement Changes in existing functionality label Jul 16, 2021
@egonspace egonspace self-assigned this Jul 16, 2021
0Tech added a commit to 0Tech/finschia-sdk that referenced this issue Oct 5, 2021
@0Tech
fix: move SigBlockHeight from TxBody into AuthInfo (Finschia#293)
f8e8635
@0Tech 0Tech mentioned this issue Oct 5, 2021
Merged
9 tasks
egonspace pushed a commit that referenced this issue Oct 5, 2021
fix: move SigBlockHeight from TxBody into AuthInfo (#344)
cc78696 
* fix: move `SigBlockHeight` from TxBody into AuthInfo (#293)

* chore: add the change into CHANGELOG.md

* fix: revert the omission of `GetSigBlockHeight()` in the tests

* fix: revert the omission `SetSigBlockHeight()` in simapp

* chore: replace the description in CHANGELOG.md into PR's

* chore: change the scope of the item into auth
@zemyblue zemyblue mentioned this issue Feb 11, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@egonspace egonspace

Labels
A: improvement Changes in existing functionality
Projects
None yet
Milestone
CBDC functional requirements
Development

Successfully merging a pull request may close this issue.

fix: move SigBlockHeight from TxBody into AuthInfo 0Tech/finschia-sdk
1 participant
@egonspace