feat: add the api for querying next account number #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/v0.47.x #1011 +/- ##
==================================================
Coverage ? 62.01%
==================================================
Files ? 656
Lines ? 78918
Branches ? 0
==================================================
Hits ? 48939
Misses ? 27292
Partials ? 2687 |
0Tech
reviewed
May 19, 2023
0Tech
approved these changes
May 19, 2023
So, I added |
tkxkd0159
approved these changes
May 19, 2023
4 tasks
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Jun 8, 2023
* feat: add `NextAccountNumber` query api in cosmos.auth.v1beta1.query proto * feat: implement query account number in x/auth module * chore: update changelog. * fix: line error * fix: proto function typo (cherry picked from commit 94b5a52)
5 tasks
zemyblue
added a commit
that referenced
this pull request
Jun 8, 2023
…1026) * feat: add the api for querying next account number (#1011) * feat: add `NextAccountNumber` query api in cosmos.auth.v1beta1.query proto * feat: implement query account number in x/auth module * chore: update changelog. * fix: line error * fix: proto function typo (cherry picked from commit 94b5a52) * chore: update changelog * Update CHANGELOG.md Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me> --------- Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
zemyblue
added a commit
to zemyblue/finschia-sdk
that referenced
this pull request
Jul 4, 2023
* feat: add `NextAccountNumber` query api in cosmos.auth.v1beta1.query proto * feat: implement query account number in x/auth module * chore: update changelog. * fix: line error * fix: proto function typo (cherry picked from commit 94b5a52)
5 tasks
This was referenced Jul 18, 2023
Merged
4 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1001
Add the query api that can query next account number.
This api is temporary api. So I added deprecated annotation.
And the
GetNextAccountNumberfunction of bank keeper return the next global account number and increments the number, so I added another similar function asQueryNextAccountNumber.QueryNextAccountNumberfunction is equals with some parts ofGetNextAccountNumberfunction. But I just copy and paste this part, because this is temporary function.I want to use the function name as
NextAccountIndex, but the inside codes almost useNextAccountNumber. So I useNextAccountNumber. Please don't confuse this is not a query api for querying the number of accounts.Added part
NextAccountNumberquery api incosmos.bank.v1beta1.queryprotoGetNextAccountNumberfunction in bank keeperNextAccountNumberand test.Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml