Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom r/w gRPC options (backport #1017) #1019

Merged
merged 2 commits into from
May 30, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented May 27, 2023

Description

backport #1017 to v0.47.1

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue added the A: bug Something isn't working label May 27, 2023
@zemyblue zemyblue self-assigned this May 27, 2023
@codecov
Copy link

codecov bot commented May 27, 2023

Codecov Report

Merging #1019 (eaa5489) into release/v0.47.x (94b5a52) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v0.47.x    #1019   +/-   ##
================================================
  Coverage            62.01%   62.01%           
================================================
  Files                  656      656           
  Lines                78918    78937   +19     
================================================
+ Hits                 48938    48950   +12     
- Misses               27293    27298    +5     
- Partials              2687     2689    +2     
Impacted Files Coverage Δ
server/config/toml.go 20.00% <ø> (ø)
server/config/config.go 43.42% <50.00%> (+0.17%) ⬆️
server/grpc/server.go 63.04% <71.42%> (-1.48%) ⬇️
testutil/network/util.go 70.86% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit 8a1dac4 into Finschia:release/v0.47.x May 30, 2023
@zemyblue zemyblue deleted the feat/pr1017_to0.47.1 branch May 30, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants