-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change the proof.proto path to third_party/proto/confio #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
170210
changed the title
chore: change the proof.proto path to third_party/proto/confio
refactor: change the proof.proto path to third_party/proto/confio
Jul 11, 2023
Signed-off-by: 170210 <j170210@icloud.com>
170210
force-pushed
the
feature/issue_767
branch
from
July 11, 2023 01:34
0b588df
to
b508e4b
Compare
zemyblue
reviewed
Jul 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add changelog in CHANGELOGS.md
Signed-off-by: 170210 <j170210@icloud.com>
170210
added
A: improvement
Changes in existing functionality
good first issue
Good for newcomers
and removed
good first issue
Good for newcomers
labels
Jul 11, 2023
tnasu
approved these changes
Jul 11, 2023
zemyblue
approved these changes
Jul 12, 2023
It seems like this PR is good because fixed path is the same path of cosmos-sdk. #651 is irrelevant as it is for ibc-go. |
Merged
4 tasks
0Tech
added a commit
to 0Tech/ibc-go
that referenced
this pull request
Aug 1, 2023
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has following changes.
closes: #767
Motivation and context
#767
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml