Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update x/collection cli for hackwasm2023 #1038

Merged
merged 3 commits into from
Jul 12, 2023
Merged

feat: update x/collection cli for hackwasm2023 #1038

merged 3 commits into from
Jul 12, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jul 12, 2023 •
edited
Loading

Description

This patch would:

  • add burn cli cmds to x/collection
  • allow minting tokens of multiple classes

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added A: improvement Changes in existing functionality C:x/collection labels Jul 12, 2023
@0Tech 0Tech self-assigned this Jul 12, 2023
@0Tech 0Tech mentioned this pull request Jul 12, 2023
Merged
4 tasks
@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (hackwasm2023@4f96389). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             hackwasm2023    #1038   +/-   ##
===============================================
  Coverage                ?   62.03%           
===============================================
  Files                   ?      655           
  Lines                   ?    78938           
  Branches                ?        0           
===============================================
  Hits                    ?    48973           
  Misses                  ?    27283           
  Partials                ?     2682

@0Tech 0Tech marked this pull request as ready for review July 12, 2023 04:38
@0Tech 0Tech requested review from zemyblue and tkxkd0159 July 12, 2023 04:38
jaeseung-bae
jaeseung-bae approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@jaeseung-bae jaeseung-bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit edb1434 into Finschia:hackwasm2023 Jul 12, 2023
29 checks passed
@0Tech 0Tech deleted the hackwasm2023 branch July 12, 2023 05:30
0Tech added a commit to 0Tech/finschia that referenced this pull request Jul 12, 2023
@0Tech
Apply Finschia/finschia-sdk#1038
7aa9cd9
0Tech added a commit to Finschia/finschia that referenced this pull request Jul 12, 2023
@0Tech
build: update finschia-sdk to hackwasm2023 (#232)
f5eb0ef 
* Use hackwasm2023 branch of finschia-sdk

* Update CHANGELOG.md

* Apply Finschia/finschia-sdk#1038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemyblue zemyblue zemyblue approved these changes

@dudong2 dudong2 dudong2 approved these changes

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159

@loin3 loin3 Awaiting requested review from loin3

Assignees

@0Tech 0Tech

Labels
A: improvement Changes in existing functionality C:x/collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0Tech @zemyblue @dudong2 @jaeseung-bae