Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tag comments in github actions workflow docker.yml #1078

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

loloicci
Copy link
Contributor

@loloicci loloicci commented Aug 10, 2023

This PR fixes some comments in workflow.
This workflow does not triggered tags without patch number.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. (not needed)
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml(not needed)

Fix some comments in workflows.
@loloicci loloicci requested a review from zemyblue August 10, 2023 07:28
@loloicci loloicci changed the title chore: Update docker.yml chore: fix some comments in github actions workflow docker.yml Aug 10, 2023
@loloicci loloicci changed the title chore: fix some comments in github actions workflow docker.yml chore: fix tag comments in github actions workflow docker.yml Aug 10, 2023
@loloicci loloicci self-assigned this Aug 10, 2023
@zemyblue zemyblue requested review from 0Tech and jaeseung-bae August 10, 2023 09:23
@loloicci loloicci merged commit 8eb450b into main Sep 11, 2023
@loloicci loloicci deleted the fix-workflow-tag-comment branch September 11, 2023 07:34
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Oct 17, 2023
* main:
  chore(deps): Bump github.com/prometheus/client_golang (Finschia#1132)
  feat: add update-censorship cmd to x/foundation cli (Finschia#1121)
  chore(deps): Bump actions/checkout from 3 to 4 (Finschia#1110)
  chore(deps): Bump actions/cache from 3.3.1 to 3.3.2 (Finschia#1119)
  chore(deps): Bump docker/build-push-action from 4 to 5 (Finschia#1123)
  chore(deps): Bump docker/login-action from 2 to 3 (Finschia#1124)
  chore(deps): Bump docker/metadata-action from 4 to 5 (Finschia#1125)
  chore(deps): Bump github.com/hashicorp/golang-lru from 0.5.5-0.20210104140557-80c98217689d to 1.0.2 (Finschia#1074)
  chore(deps): Bump github.com/go-kit/kit from 0.12.0 to 0.13.0 (Finschia#1097)
  chore(deps): Bump golang.org/x/crypto from 0.11.0 to 0.13.0 (Finschia#1111)
  chore: fix tag comments in github actions workflow docker.yml (Finschia#1078)
  docs: update links in x/foundation README.md (Finschia#1120)
  docs: create ERRORS.md for x/module (Finschia#1059)

# Conflicts:
#	CHANGELOG.md
#	Makefile
#	go.mod
#	go.sum
jaeseung-bae pushed a commit to jaeseung-bae/finschia-sdk that referenced this pull request May 7, 2024
…ia#1078)

* Update docker.yml

Fix some comments in workflows.

* docs: add this PR to CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants