Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove libsodium vrf library. #1098

Closed

Conversation

Kynea0b
Copy link
Contributor

@Kynea0b Kynea0b commented Aug 28, 2023

Description

Remove unused shared library

  • libsodium

Motivation and context

Same as this pr. Finschia/finschia#240

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. (not needed)
  • I have updated the documentation accordingly. (not needed)
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml (not needed)

170210 and others added 2 commits August 9, 2023 17:17
* chore: create an automatic error document generation module

Signed-off-by: 170210 <j170210@icloud.com>

* docs: generate ERRORS.md for x/module

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add a ci to check generated error docs up-to-date

Signed-off-by: 170210 <j170210@icloud.com>

* chore: update changelog

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: fix for lint

Signed-off-by: 170210 <j170210@icloud.com>

* style: format yml file

Signed-off-by: 170210 <j170210@icloud.com>

* fixup: fix for review

Signed-off-by: 170210 <j170210@icloud.com>

* fixup: fix for review

Signed-off-by: 170210 <j170210@icloud.com>

* fixup: refactor by comment

Signed-off-by: 170210 <j170210@icloud.com>

* fixup: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

* fixup: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>
@Kynea0b Kynea0b marked this pull request as draft August 28, 2023 05:40
@Kynea0b Kynea0b self-assigned this Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1098 (325b868) into rc/v0.48.0-rcx (c057de9) will decrease coverage by 7.68%.
Report is 2 commits behind head on rc/v0.48.0-rcx.
The diff coverage is n/a.

❗ Current head 325b868 differs from pull request most recent head bf05f8a. Consider uploading reports for the commit bf05f8a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           rc/v0.48.0-rcx    #1098      +/-   ##
==================================================
- Coverage           69.70%   62.02%   -7.68%     
==================================================
  Files                 642      656      +14     
  Lines               67287    78937   +11650     
==================================================
+ Hits                46902    48962    +2060     
- Misses              18203    27286    +9083     
- Partials             2182     2689     +507     

see 33 files with indirect coverage changes

@Kynea0b Kynea0b marked this pull request as ready for review August 28, 2023 06:15
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pease change the target branch to rc/v0.48.0-rcx.

@Kynea0b Kynea0b changed the base branch from main to rc/v0.48.0-rcx August 28, 2023 06:40
@Kynea0b
Copy link
Contributor Author

Kynea0b commented Aug 28, 2023

Sorry. Replace this PR with here. #1099

@Kynea0b Kynea0b closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants