Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more unittest for MsgGrantPermission and MsgRevokePermission of x/token #1129

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Sep 22, 2023

Description

  • add more unittest for MsgGrantPermission and MsgRevokePermission of x/token

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #1129 (53970c9) into rc/v0.48.0-rcx (d9c5d42) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1129   +/-   ##
===============================================
  Coverage           69.77%   69.77%           
===============================================
  Files                 645      645           
  Lines               67482    67482           
===============================================
  Hits                47083    47083           
  Misses              18212    18212           
  Partials             2187     2187           

@zemyblue zemyblue self-assigned this Sep 22, 2023
@zemyblue zemyblue marked this pull request as ready for review September 22, 2023 11:33
jaeseung-bae
jaeseung-bae previously approved these changes Sep 25, 2023
@zemyblue
Copy link
Member Author

@jaeseung-bae I reformated the expected events. Please review it again.

@zemyblue zemyblue merged commit 6f75458 into Finschia:rc/v0.48.0-rcx Sep 25, 2023
36 checks passed
@zemyblue zemyblue deleted the feat/add_unittest_token_grantpermission branch September 25, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants