Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for event compatibility #1137

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Oct 10, 2023

Description

  • add test for event compatibility with literal event structure that was used previously
  • These tests act as regression tests for event structure

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #1137 (2c5e96a) into rc/v0.48.0-rcx (44c406b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           rc/v0.48.0-rcx    #1137      +/-   ##
==================================================
- Coverage           69.77%   69.77%   -0.01%     
==================================================
  Files                 645      645              
  Lines               67482    67482              
==================================================
- Hits                47087    47086       -1     
- Misses              18209    18210       +1     
  Partials             2186     2186              

see 1 file with indirect coverage changes

@jaeseung-bae jaeseung-bae marked this pull request as ready for review October 12, 2023 05:21
@jaeseung-bae jaeseung-bae self-assigned this Oct 12, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
@jaeseung-bae jaeseung-bae changed the title test: add test for event compatability test: add test for event compatibility Oct 12, 2023
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaeseung-bae jaeseung-bae merged commit 8920362 into Finschia:rc/v0.48.0-rcx Oct 13, 2023
37 checks passed
@jaeseung-bae jaeseung-bae deleted the test/token branch October 13, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants