-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare the signer of the normal message and the signer of MsgExcute #1291
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/zkauth #1291 +/- ##
==============================================
Coverage ? 69.57%
==============================================
Files ? 659
Lines ? 68385
Branches ? 0
==============================================
Hits ? 47577
Misses ? 18553
Partials ? 2255
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding a test case with the wrong zk signer?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Currently, msgs signer validation is not performed when dispatching msgs of MsgExcute.
This leads to serious problems such as fraudulent transfers.
This can be prevented by making sure that the signer of the msg executed when dispatching msg is the signer of MsgExcute.
We will have to discuss later whether this modification is sufficient.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml