-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch a failed proposal tally from proposal.FinalTallyResult in the gprc query #1304
Conversation
Signed-off-by: 170210 <j170210@icloud.com>
|
Signed-off-by: 170210 <j170210@icloud.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1304 +/- ##
=======================================
Coverage 70.42% 70.43%
=======================================
Files 643 643
Lines 54730 54730
=======================================
+ Hits 38546 38547 +1
+ Misses 14011 14010 -1
Partials 2173 2173
|
Description
The TallyResult() is used to fetch the tally result from a proposal, in which the case when a proposal fails does not provide the correct information as this case has been branched into the default case.
This pr cherry-pick the following pr:
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml