Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): properly parse multiple gas config(backport cosmos/cosmos-sdk#18537) #1337

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

jaeseung-bae
Copy link
Contributor

@jaeseung-bae jaeseung-bae commented Apr 16, 2024

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024

CLA assistant check
All committers have signed the CLA.

@jaeseung-bae jaeseung-bae force-pushed the fix/backport-cosmos-18537 branch from 1684cde to 1115e78 Compare April 16, 2024 09:52
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 70.39%. Comparing base (55b6566) to head (58cf3aa).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   70.38%   70.39%           
=======================================
  Files         643      643           
  Lines       54793    54789    -4     
=======================================
+ Hits        38564    38566    +2     
+ Misses      14054    14047    -7     
- Partials     2175     2176    +1     
Files Coverage Δ
server/config/toml.go 15.78% <ø> (ø)
server/config/config.go 46.32% <33.33%> (+2.75%) ⬆️

@jaeseung-bae jaeseung-bae marked this pull request as ready for review April 16, 2024 10:43
@jaeseung-bae jaeseung-bae requested a review from 170210 April 16, 2024 10:43
CHANGELOG.md Outdated Show resolved Hide resolved
@jaeseung-bae jaeseung-bae merged commit 7849929 into main Apr 26, 2024
37 of 38 checks passed
@jaeseung-bae jaeseung-bae deleted the fix/backport-cosmos-18537 branch April 26, 2024 07:50
mergify bot pushed a commit that referenced this pull request Apr 26, 2024
…s-sdk#18537) (#1337)

* fix(server): properly parse multiple gas config(backport cosmos-sdk#18537)

* chore: update changelog

* chore: add missing PR link

(cherry picked from commit 7849929)
mergify bot pushed a commit that referenced this pull request Apr 26, 2024
…s-sdk#18537) (#1337)

* fix(server): properly parse multiple gas config(backport cosmos-sdk#18537)

* chore: update changelog

* chore: add missing PR link

(cherry picked from commit 7849929)

# Conflicts:
#	CHANGELOG.md
jaeseung-bae added a commit that referenced this pull request May 6, 2024
…s-sdk#18537) (#1337) (#1343)

* fix(server): properly parse multiple gas config(backport cosmos-sdk#18537)

* chore: update changelog

* chore: add missing PR link

(cherry picked from commit 7849929)

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
0Tech added a commit that referenced this pull request May 24, 2024
…s-sdk#18537) (backport #1337) (#1344)

* fix(server): properly parse multiple gas config(backport cosmos/cosmos-sdk#18537) (#1337)

* fix(server): properly parse multiple gas config(backport cosmos-sdk#18537)

* chore: update changelog

* chore: add missing PR link

(cherry picked from commit 7849929)

# Conflicts:
#	CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: jaeseung-bae <119839167+jaeseung-bae@users.noreply.github.com>
Co-authored-by: Youngtaek Yoon <noreply@yoon.mailer.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants