feat(x/fbridge): set target denom as module parameters (backport #1366) #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* set fbridge target denom through params * add UpdateParams * add event and unittest * use sdk denom checker (cherry picked from commit a9be0cb)
mergify
bot
requested review from
tkxkd0159,
zemyblue,
0Tech and
jaeseung-bae
as code owners
tkxkd0159
added
A: improvement
jaeseung-bae
approved these changes
May 8, 2024
0Tech
approved these changes
May 8, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/v0.49.x #1368 +/- ##
===================================================
- Coverage 68.90% 68.87% -0.03%
===================================================
Files 675 675
Lines 69167 69199 +32
===================================================
+ Hits 47657 47659 +2
- Misses 19231 19260 +29
- Partials 2279 2280 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #XXXX
UpdateParamsto be able to change this value in the future.Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yamlThis is an automatic backport of pull request #1366 done by [Mergify](https://mergify.com).