Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing event emissions(EventSetSwap, EventAddDenomMetadata) (backport #1385) #1386

Merged
merged 2 commits into from
May 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 17, 2024

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

This is an automatic backport of pull request #1385 done by [Mergify](https://mergify.com).

)

* fix: missing event emissions(EventSetSwap, EventAddDenomMetadata)

* chore: update changelog

(cherry picked from commit baab526)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot requested a review from tkxkd0159 as a code owner May 17, 2024 00:57
@mergify mergify bot added the conflicts label May 17, 2024
@mergify mergify bot requested review from zemyblue, 0Tech and jaeseung-bae as code owners May 17, 2024 00:57
Copy link
Contributor Author

mergify bot commented May 17, 2024

Cherry-pick of baab526 has failed:

On branch mergify/bp/release/v0.49.x/pr-1385
Your branch is up to date with 'origin/release/v0.49.x'.

You are currently cherry-picking commit baab52684.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   docs/core/proto-docs.md
	modified:   proto/lbm/fswap/v1/event.proto
	modified:   x/fswap/keeper/keeper.go
	modified:   x/fswap/keeper/keeper_test.go
	modified:   x/fswap/types/event.pb.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.93%. Comparing base (2b4474c) to head (641bda2).

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.49.x    #1386      +/-   ##
===================================================
- Coverage            68.93%   68.93%   -0.01%     
===================================================
  Files                  671      671              
  Lines                69256    69260       +4     
===================================================
- Hits                 47743    47742       -1     
- Misses               19233    19236       +3     
- Partials              2280     2282       +2     
Files Coverage Δ
x/fswap/keeper/keeper.go 45.90% <20.00%> (-0.67%) ⬇️

... and 1 file with indirect coverage changes

@jaeseung-bae jaeseung-bae self-assigned this May 17, 2024
)

* fix: missing event emissions(EventSetSwap, EventAddDenomMetadata)

* chore: update changelog
@jaeseung-bae jaeseung-bae added A: bug Something isn't working and removed conflicts labels May 17, 2024
@jaeseung-bae jaeseung-bae merged commit 27c7599 into release/v0.49.x May 20, 2024
36 of 37 checks passed
@jaeseung-bae jaeseung-bae deleted the mergify/bp/release/v0.49.x/pr-1385 branch May 20, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants