chore: use txHash instead of signBytes
#32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `GetSignBytes()` is much more expensive than `sha256`
egonspace
pushed a commit
that referenced
this pull request
Mar 28, 2021
* fix wasmKeeper of x/wasm/linkwasmd for #5 * modify wasm keeper * update Makefile to refer source files of linkwasmd/cli * add a test using token module from wasm contract * execute go fmt * add a test creating a collection * modify to use json.Marshal to make message for executing contracts
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetSignBytes()is much more expensive thansha256Description
use
txHashinstead ofsignBytesbecausesignBytesis much more expensive thansha256Motivation and context
How has this been tested?
Checklist: