fix: update allowance inside AllowedMsgAllowance #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Tech
force-pushed
the
fix/feegrant_allowedmsg
branch
from
0591812 to
2d1aa31
Compare
Codecov Report
@@ Coverage Diff @@
## main #383 +/- ##
=======================================
Coverage ? 53.82%
=======================================
Files ? 674
Lines ? 69660
Branches ? 0
=======================================
Hits ? 37493
Misses ? 29160
Partials ? 3007 |
egonspace
approved these changes
Nov 17, 2021
|
I also submitted a PR on cosmos-sdk. |
zemyblue
added a commit
that referenced
this pull request
Jan 25, 2022
* main: (44 commits) feat: rewrite issue template and move PR template (#410) fix: validate validator addresses in update-validator-auths proposal (#411) feat: add `bankplus` function to restrict to send coin to inactive smart contract. (#400) build(deps): bump actions/setup-go from 2.1.4 to 2.1.5 (#408) ci: fix branch name on ci script (#409) feat: Add CreateValidator access control feature (#406) build(deps): bump github.com/spf13/viper from 1.9.0 to 1.10.1 (#403) build(deps): bump github.com/rs/zerolog from 1.26.0 to 1.26.1 (#402) fix: fix query signing infos command (#407) build(deps): bump github.com/spf13/cobra from 1.1.3 to 1.3.0 (#399) build(deps): github.com/ulikunitz/xz from 0.5.5 to 0.5.10 (#398) build(deps): bump actions/stale from 3 to 4.1.0 (#396) build(deps): bump actions/cache from 2.1.3 to 2.1.7 (#386) feat: Add the `instantiate_permission` in the `CodeInfoResponse` (#395) fix: fix bug where `StoreCodeAndInstantiateContract`, `UpdateContractStatus`, `UpdateContractStatusProposal` API does not work (#393) docs: modify with latest version of swagger REST interface docs. (#392) fix: fix invalid root hash by bumping up tm-db (#388) chore: fix swagger's config path for wasm (#391) build(deps): bump technote-space/get-diff-action from 5.0.1 to 5.0.2 (#379) fix: update allowance inside AllowedMsgAllowance (#383) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By the fix, AllowedMsgAllowance updates its allowance after the change in
Accept().To catch the corresponding issue, the fix also adds new unit tests.
closes: #382
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes