Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove x/wasm/linkwasmd #436

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

zemyblue
Copy link
Member

Description

Remove x/wasm/linkwasmd codes because these doesn't use any more in lbm-sdk.
closes: #435

Motivation and context

  1. We don't maintain these codes any more.
  2. These codes isn't compiled because doesn't apply latest changes.
  3. These codes are occurred lint error.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue self-assigned this Feb 14, 2022
Copy link
Contributor

@iproudhon iproudhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit 43a3d53 into Finschia:main Feb 15, 2022
@zemyblue zemyblue mentioned this pull request Mar 4, 2022
5 tasks
zemyblue added a commit to zemyblue/finschia-sdk that referenced this pull request Mar 4, 2022
* main:
  fix: `make proto-format` bug in the Makefile (Finschia#438)
  feat: Revert sig_block_height (Finschia#434)
  build(deps): bump actions/setup-go from 2.1.5 to 2.2.0 (Finschia#432)
  build(deps): bump github.com/prometheus/client_golang (Finschia#424)
  chore: remove `x/wasm/linkwasmd` (Finschia#436)
  build(deps): bump github.com/VictoriaMetrics/fastcache (Finschia#429)
  fix: apply fix from release branch (Finschia#428)

# Conflicts:
#	CHANGELOG.md
@zemyblue zemyblue deleted the remove_linkwasmd branch May 19, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove x/wasm/linkwasmd
3 participants