Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gasWanted & gasUsed are always 0 #51

Merged
merged 2 commits into from
Jan 22, 2021
Merged

fix: gasWanted & gasUsed are always 0 #51

merged 2 commits into from
Jan 22, 2021

Conversation

jinsan-line
Copy link
Contributor

Related with: https://github.com/line/link/issues/1151, #49

Description

W/ #49, we introduce a bug that gasWanted and gasUsed are always 0. I'd like to fix it w/ this PR.

Motivation and context

How has this been tested?

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@jinsan-line jinsan-line self-assigned this Jan 22, 2021
Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinsan-line jinsan-line merged commit cdf35e6 into Finschia:feat/perf Jan 22, 2021
@jinsan-line jinsan-line deleted the fix-concurrent-checktx branch January 22, 2021 10:20
egonspace pushed a commit that referenced this pull request Mar 28, 2021
* refactoring: use var defined in types as expected default value of wasm parameters

* add test for change the parameter MaxWasmCodeSize

* Add documentation
jinsan-line added a commit that referenced this pull request Apr 22, 2021
* fix: gasWanted & gasUsed is always `0`

* chore: error log for general panic
# Conflicts:
#	baseapp/baseapp.go
@jinsan-line jinsan-line mentioned this pull request Apr 22, 2021
9 tasks
jinsan-line added a commit that referenced this pull request Apr 22, 2021
* chore: bump up ostracon, iavl and tm-db

* feat: concurrent checkTx (#49)

* feat: implement new abci, `BeginRecheckTx()` and `EndRecheckTx()`

* test: fix tests

* refactor: decompose checkTx & runTx

* chore: protect app.checkState w/ RWMutex for simulate

* chore: remove unused var

* feat: account lock decorator

* chore: skip AccountLockDecorator if not checkTx

* chore: bump up tendermint

* chore: revise accountlock position

* chore: accountlock_test

* chore: revise accountlock covers `cache.Write()`

* chore: revise `sampleBytes` to `2`

* fix: test according to `sampleBytes`

* chore: revise `getUniqSortedAddressKey()` and add `getAddressKey()`

* chore: revise `how to sort` not to use `reflection`

* chore: bump up tendermint

* test: check `sorted` in `TestGetUniqSortedAddressKey()`

* chore: move `accountLock` from `anteTx()` to `checkTx()`
# Conflicts:
#	baseapp/abci.go
#	baseapp/baseapp.go
#	baseapp/baseapp_test.go
#	baseapp/helpers.go
#	go.mod
#	go.sum
#	x/bank/bench_test.go
#	x/mock/test_utils.go

* fix: make it buildable

* fix: tests

* fix: gasWanted & gasUsed are always `0` (#51)

* fix: gasWanted & gasUsed is always `0`

* chore: error log for general panic
# Conflicts:
#	baseapp/baseapp.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants