Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check pubkey type from validator params #724

Merged
merged 7 commits into from
Oct 18, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Oct 17, 2022

Description

Currently, the ValidateValidatorParams function does not check the pubkey type.
So, no error is returned even if an illegal pubkey type is passed as param.
closes: #723

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 added the A: bug Something isn't working label Oct 17, 2022
@dudong2 dudong2 self-assigned this Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #724 (d6cb662) into main (502bfd7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   61.97%   61.98%   +0.01%     
==========================================
  Files         874      874              
  Lines       98797    98803       +6     
==========================================
+ Hits        61225    61246      +21     
+ Misses      33928    33924       -4     
+ Partials     3644     3633      -11     
Impacted Files Coverage Δ
baseapp/params.go 100.00% <100.00%> (ø)
x/token/msgs.go 34.51% <0.00%> (-4.07%) ⬇️
x/collection/collection.go 80.35% <0.00%> (+1.78%) ⬆️
x/collection/msgs.go 41.66% <0.00%> (+3.33%) ⬆️
x/token/validation.go 92.72% <0.00%> (+3.63%) ⬆️

Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@tkxkd0159 tkxkd0159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dudong2 and others added 2 commits October 18, 2022 11:58
Co-authored-by: Youngtaek Yoon <noreply@yoon.anonaddy.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check alllowed pubkey type
3 participants