-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check multisig key list to prevent unexpected key deletion #737
Conversation
add `verifyMultisigTarget`
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #737 +/- ##
==========================================
- Coverage 62.08% 62.05% -0.04%
==========================================
Files 877 877
Lines 98970 98964 -6
==========================================
- Hits 61450 61414 -36
- Misses 33900 33933 +33
+ Partials 3620 3617 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does not seem to implement second recommended check Check if the Multisig contains the same name that will be overridden, and return an error to remind the users of trying a different name.
.
add
verifyMultisigTarget
Description
closes: #717
Motivation and context
How has this been tested?
Test by CLI with the audit scenario.
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml