Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant granter from x/foundation events #757

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 26, 2022

Description

This patch will remove the redundant field in the events.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #757 (4588c9b) into main (ea17c5a) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   62.15%   62.16%           
=======================================
  Files         879      879           
  Lines       99371    99366    -5     
=======================================
+ Hits        61767    61771    +4     
- Misses      33979    33983    +4     
+ Partials     3625     3612   -13     
Impacted Files Coverage Δ
x/foundation/keeper/grant.go 72.04% <ø> (-1.43%) ⬇️
x/token/msgs.go 49.42% <0.00%> (ø)
x/collection/msgs.go 53.57% <0.00%> (+0.14%) ⬆️
x/token/validation.go 85.45% <0.00%> (+14.54%) ⬆️

@0Tech 0Tech marked this pull request as ready for review October 26, 2022 04:50
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 26, 2022
@0Tech 0Tech merged commit 73a741b into Finschia:main Oct 26, 2022
@0Tech 0Tech deleted the foundation_event branch October 26, 2022 07:47
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants