Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implemented method SetOption() #781

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Nov 3, 2022

Description

  • Implemented method SetOption()

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue added the A: bug Something isn't working label Nov 3, 2022
@zemyblue zemyblue self-assigned this Nov 3, 2022
@zemyblue zemyblue marked this pull request as draft November 3, 2022 06:08
@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

❗ No coverage uploaded for pull request base (rc9/v0.46.0@c50f198). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             rc9/v0.46.0     #781   +/-   ##
==============================================
  Coverage               ?   62.14%           
==============================================
  Files                  ?      880           
  Lines                  ?    99479           
  Branches               ?        0           
==============================================
  Hits                   ?    61820           
  Misses                 ?    34057           
  Partials               ?     3602           

Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue marked this pull request as ready for review November 3, 2022 08:27
baseapp/abci.go Show resolved Hide resolved
@zemyblue zemyblue requested a review from 0Tech November 7, 2022 06:08
@zemyblue zemyblue merged commit 9c041c4 into Finschia:rc9/v0.46.0 Nov 7, 2022
This was referenced Nov 22, 2022
@zemyblue zemyblue deleted the zemyblue/setoption branch December 23, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants