Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix test flow to install libsodium #803

Merged
merged 9 commits into from
Nov 21, 2022

Conversation

ulbqb
Copy link
Member

@ulbqb ulbqb commented Nov 18, 2022

Description

This PR has following changes.

  • add test.yml to diff target in test.yml
  • add step to install libsodium

related: #801

Motivation and context

Even if ci test is changed, the test is skipped. I missed that it had to install libsodium because of that.

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@ulbqb ulbqb changed the base branch from main to rc9/v0.46.0 November 18, 2022 08:21
@ulbqb ulbqb self-assigned this Nov 18, 2022
@ulbqb ulbqb force-pushed the fix/libsodium_installing branch 5 times, most recently from 1899baa to 150f36b Compare November 18, 2022 10:12
@ulbqb ulbqb force-pushed the fix/libsodium_installing branch from 150f36b to 37b27cc Compare November 18, 2022 10:17
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #803 (370682c) into rc9/v0.46.0 (6792efe) will increase coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 370682c differs from pull request most recent head d8420de. Consider uploading reports for the commit d8420de to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc9/v0.46.0     #803      +/-   ##
===============================================
+ Coverage        62.15%   62.20%   +0.04%     
===============================================
  Files              877      877              
  Lines            99419    99419              
===============================================
+ Hits             61796    61845      +49     
+ Misses           34019    33960      -59     
- Partials          3604     3614      +10     
Impacted Files Coverage Δ
x/collection/keeper/supply.go 89.11% <100.00%> (ø)
x/token/validation.go 72.72% <0.00%> (-12.73%) ⬇️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️
x/wasm/keeper/keeper.go 86.53% <0.00%> (+0.36%) ⬆️
x/token/msgs.go 53.99% <0.00%> (+4.56%) ⬆️
x/collection/msgs.go 53.72% <0.00%> (+5.80%) ⬆️
x/token/token.go 100.00% <0.00%> (+50.00%) ⬆️

@ulbqb ulbqb requested review from 0Tech, zemyblue and tnasu November 18, 2022 10:33
@ulbqb ulbqb marked this pull request as ready for review November 18, 2022 10:44
CHANGELOG.md Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@ulbqb ulbqb merged commit b13f437 into Finschia:rc9/v0.46.0 Nov 21, 2022
@ulbqb ulbqb deleted the fix/libsodium_installing branch November 21, 2022 04:04
This was referenced Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants