-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix test flow to install libsodium #803
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulbqb
force-pushed
the
fix/libsodium_installing
branch
5 times, most recently
from
November 18, 2022 10:12
1899baa
to
150f36b
Compare
ulbqb
force-pushed
the
fix/libsodium_installing
branch
from
November 18, 2022 10:17
150f36b
to
37b27cc
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc9/v0.46.0 #803 +/- ##
===============================================
+ Coverage 62.15% 62.20% +0.04%
===============================================
Files 877 877
Lines 99419 99419
===============================================
+ Hits 61796 61845 +49
+ Misses 34019 33960 -59
- Partials 3604 3614 +10
|
0Tech
approved these changes
Nov 21, 2022
dudong2
approved these changes
Nov 21, 2022
zemyblue
approved these changes
Nov 21, 2022
This was referenced Nov 22, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR has following changes.
related: #801
Motivation and context
Even if ci test is changed, the test is skipped. I missed that it had to install libsodium because of that.
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml