-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: introduce codespace into x/collection,token #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TransferFT, TransferFTFrom, TransferNFT & TransferNFTFrom
0Tech
requested review from
dudong2,
jaeseung-bae,
loin3,
tkxkd0159 and
zemyblue
January 3, 2023 08:42
5 tasks
zemyblue
reviewed
Jan 12, 2023
zemyblue
reviewed
Jan 16, 2023
tkxkd0159
reviewed
Jan 17, 2023
jaeseung-bae
approved these changes
Jan 19, 2023
5 tasks
tkxkd0159
approved these changes
Jan 20, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch would import codespace for x/collection,token errors, and make the modules to emit the exactly same errors as daphne does.
Note: It would affect the performance of the target modules.
Motivation and context
Our client requires it.
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml