Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: introduce codespace into x/collection,token #849

Merged
merged 84 commits into from
Jan 20, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Jan 3, 2023

Description

This patch would import codespace for x/collection,token errors, and make the modules to emit the exactly same errors as daphne does.

Note: It would affect the performance of the target modules.

Motivation and context

Our client requires it.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech marked this pull request as ready for review January 3, 2023 08:42
types/errors/link.go Show resolved Hide resolved
types/errors/link.go Outdated Show resolved Hide resolved
x/collection/errors.go Outdated Show resolved Hide resolved
x/collection/keeper/grpc_query.go Outdated Show resolved Hide resolved
@0Tech 0Tech requested a review from zemyblue January 13, 2023 01:41
@0Tech 0Tech requested a review from zemyblue January 17, 2023 05:28
x/collection/keeper/grpc_query_test.go Outdated Show resolved Hide resolved
x/collection/keeper/nft.go Outdated Show resolved Hide resolved
x/collection/keeper/nft.go Show resolved Hide resolved
simapp/app.go Show resolved Hide resolved
x/token/keeper/send.go Show resolved Hide resolved
@0Tech 0Tech mentioned this pull request Jan 20, 2023
5 tasks
@0Tech 0Tech merged commit 1deccf3 into Finschia:main Jan 20, 2023
@0Tech 0Tech deleted the daphne_errors branch January 20, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants