Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update comments in the x/token,collection events proto #940

Closed
wants to merge 0 commits into from

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 22, 2023

Description

This patch would update the comments relevant to the changes in PR #900.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Mar 22, 2023
@0Tech 0Tech added documentation Improvements or additions to documentation C:x/collection C:x/token labels Mar 22, 2023
@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #940 (011d867) into main (b57f364) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #940   +/-   ##
=======================================
  Coverage   62.38%   62.38%           
=======================================
  Files         655      655           
  Lines       79818    79818           
=======================================
  Hits        49795    49795           
  Misses      27338    27338           
  Partials     2685     2685           

@0Tech 0Tech marked this pull request as ready for review March 22, 2023 12:02
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this pr need to be apply in lbm-sdk v0.47.0, please change the target branch to rc/v0.47.0-alpha1.

@0Tech 0Tech changed the base branch from main to rc1/v0.1.0 March 28, 2023 05:24
@0Tech 0Tech closed this Mar 28, 2023
@0Tech
Copy link
Collaborator Author

0Tech commented Mar 28, 2023

Closing in favor of #944.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/collection C:x/token documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants