Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add x/token and x/collection #138

Merged
merged 3 commits into from
Feb 10, 2023
Merged

feat: add x/token and x/collection #138

merged 3 commits into from
Feb 10, 2023

Conversation

0Tech
Copy link
Contributor

@0Tech 0Tech commented Feb 10, 2023 •
edited
Loading

Description

Closes: #134

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@0Tech 0Tech self-assigned this Feb 10, 2023
@0Tech 0Tech marked this pull request as ready for review February 10, 2023 07:44
jaeseung-bae
jaeseung-bae previously approved these changes Feb 10, 2023
View reviewed changes
zemyblue
zemyblue approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue self-requested a review February 10, 2023 08:32
zemyblue
zemyblue previously approved these changes Feb 10, 2023
View reviewed changes
@zemyblue
Copy link
Member

zemyblue commented Feb 10, 2023 •
edited
Loading

Oh? Why is there no class in app_test.go? Is it no need?

@zemyblue zemyblue closed this Feb 10, 2023
@zemyblue zemyblue reopened this Feb 10, 2023
@0Tech 0Tech dismissed stale reviews from zemyblue and jaeseung-bae via 9c0f8b4 February 10, 2023 08:41
@0Tech 0Tech merged commit e2ee72c into main Feb 10, 2023
@0Tech 0Tech deleted the add_modules branch February 10, 2023 09:27
@zemyblue zemyblue mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@zemyblue zemyblue zemyblue approved these changes

@dudong2 dudong2 Awaiting requested review from dudong2

@loin3 loin3 Awaiting requested review from loin3

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159 tkxkd0159 is a code owner

Assignees

@0Tech 0Tech

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add x/token and x/collection of lbm-sdk
3 participants
@0Tech @zemyblue @jaeseung-bae