Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change wasm module to wrapped x/wasmplus #141

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 13, 2023

Description

  • apply x/wasmplus module of line/wasmd
    • x/wasmplus is the module that custom features for lbm are separated from x/wasm .
    • But there is not any API difference with previous lbm version

closes: #136

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue
Copy link
Member Author

In this PR, we need to add TXCounterStoreKeyAnteHandler for wasm module, but this AnteHandler is not calculated as gas simulate, so an error occurred during --gas=auto unittest, so we will check this part in the next version except for now and add it again. Added as an issue with #142.

Copy link
Contributor

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zemyblue zemyblue merged commit be5785b into main Feb 13, 2023
@zemyblue zemyblue deleted the feat/apply_wasmplus branch February 13, 2023 07:30
@zemyblue zemyblue mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add line/wasmplus module
3 participants