Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the Makefile to build release bundles #150

Merged
merged 7 commits into from
Mar 6, 2023

Conversation

torao
Copy link
Contributor

@torao torao commented Feb 21, 2023

Description

This PR enables the creation of release bundles (e.g., lbm-v0.0.0-linux-arm64.tgz), which is currently done by Github Actions. The following commands can be used to create LBM executable binaries of different architectures in a local environment.

$ go env GOARCH         
arm64
$ go env -w GOARCH=amd64
$ make clean build-release-bundle
...
OK: Test execution confirmed.
Built: .../lbm/build/lbm-v0.0.0-darwin-amd64.tgz
$ ls build
lbm lbm-v0.0.0-darwin-amd64.tgz

In addition, the creation of release bundles, which is currently done via Github Actions, has been changed to simply run this make command, and the build in the Dockerfile has been changed to retrieve the libwasmvm.a library in the same way.

Note that it's still not possible to build for different operating systems, as a native build is required.

Motivation and context

related with #116.

How has this been tested?

  • Release bundles are created by local command execution.
  • As before, the release was created by the CI created the release using a version tag.

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@torao torao added the enhancement New feature or request label Feb 21, 2023
@torao torao self-assigned this Feb 21, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
@torao torao requested a review from zemyblue February 21, 2023 09:50
@torao torao requested a review from tkxkd0159 February 28, 2023 09:59
@torao torao merged commit f10051e into rc/v1.0.0-rc0 Mar 6, 2023
@torao torao deleted the feature/build_release_bundle_by_makefile branch March 6, 2023 05:33
zemyblue added a commit that referenced this pull request Mar 13, 2023
…o_finschia

* commit 'f10051e0e3be6352429b3e123d8b07247c919d9f':
  Modify the Makefile to build release bundles (#150)
  chore: update wasmd version (#147)
@zemyblue zemyblue mentioned this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants