Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: rename and bump up dependencies #176

Merged
merged 17 commits into from
Apr 19, 2023
Merged

build: rename and bump up dependencies #176

merged 17 commits into from
Apr 19, 2023

Conversation

0Tech
Copy link
Contributor

@0Tech 0Tech commented Apr 19, 2023 •
edited
Loading

Description

This patch would:

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@0Tech
Rename & bump up dependencies
662dfdf 
- github.com/line/lbm-sdk => github.com/Finschia/finschia-sdk
- github.com/line/ostracon => github.com/Finschia/ostracon
- github.com/line/ibc-go => github.com/Finschia/ibc-go
- github.com/line/wasmd => github.com/Finschia/wasmd
@0Tech
Rename module name from github.com/line/finschia to github.com/Finsch…
dfc8009 
…ia/finschia
@0Tech 0Tech added the dependencies Pull requests that update a dependency file label Apr 19, 2023
@0Tech 0Tech self-assigned this Apr 19, 2023
@0Tech 0Tech marked this pull request as ready for review April 19, 2023 09:41
zemyblue
zemyblue reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check below files and change the link from line/lbm or line/finschia, etc.

  • .releaserc
  • CHANGELOG.md
  • CONTRIBUTIONG.md
  • README.md
  • RELEASE_NOTE.md

@0Tech
Copy link
Contributor Author

0Tech commented Apr 19, 2023

Please check below files and change the link from line/lbm or line/finschia, etc.

* .releaserc

* CHANGELOG.md

* CONTRIBUTIONG.md

* README.md

* RELEASE_NOTE.md

I thought they would be addressed by another PR. Should I update them right now?

@zemyblue
Copy link
Member

Please check below files and change the link from line/lbm or line/finschia, etc.

* .releaserc

* CHANGELOG.md

* CONTRIBUTIONG.md

* README.md

* RELEASE_NOTE.md

I thought they would be addressed by another PR. Should I update them right now?

If you want, please add another PR.

zemyblue
zemyblue previously approved these changes Apr 19, 2023
View reviewed changes
zemyblue
zemyblue reviewed Apr 19, 2023
View reviewed changes
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check .goreleaser.yml

finschia/.goreleaser.yml

Lines 18 to 22 in fad6987

- -X github.com/line/lbm-sdk/version.Name=finschia
- -X github.com/line/lbm-sdk/version.ServerName=finschia
- -X github.com/line/lbm-sdk/version.Version={{ .Version }}
- -X github.com/line/lbm-sdk/version.Commit={{ .FullCommit }}
- -X "github.com/line/lbm-sdk/version.BuildTags=netgo,ledger"

@zemyblue zemyblue self-requested a review April 19, 2023 10:20
@0Tech
Copy link
Contributor Author

0Tech commented Apr 19, 2023

There are several "line" related things remaining:

@0Tech
Copy link
Contributor Author

0Tech commented Apr 19, 2023 •
edited
Loading

Also, the pushing repository name would be updated to finschia/finschianode. I found the name in many targets in Makefile.
If you want to change the name, please let me know. I have no strong opinion on this subject.

zemyblue
zemyblue reviewed Apr 19, 2023
View reviewed changes
cli_test/test_helpers.go Outdated Show resolved Hide resolved
zemyblue
zemyblue reviewed Apr 19, 2023
View reviewed changes
RELEASE_CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech merged commit 0a4caa2 into rc/v1.0.0-rc0 Apr 19, 2023
@0Tech 0Tech deleted the rename-and-bump-up branch April 19, 2023 12:29
zemyblue added a commit to zemyblue/finschia that referenced this pull request Apr 21, 2023
@zemyblue
Merge branch 'rc/v1.0.0-rc0' into feat/backport_rc7
ba334c1 
* rc/v1.0.0-rc0: (26 commits)
  ci: add a ci to build darwin version when add tag (Finschia#180)
  chore: Release v1.0.0-rc7 (Finschia#179)
  Bump github.com/Finschia/finschia-sdk from v0.47.0-rc6 to v0.47.0-rc7 (Finschia#178)
  chore: Release v1.0.0-rc6 (Finschia#177)
  build: rename and bump up dependencies (Finschia#176)
  chore: bump up lbm-sdk from v0.47.0-rc5 to v0.47.0-rc5.0.20230414034539-489c442416cd (Finschia#174)
  chore: Release v1.0.0-rc5 (Finschia#173)
  Bump github.com/line/lbm-sdk from v0.47.0-rc4.0.20230410115856-b8421116b3f2 to v0.47.0-rc5 (Finschia#172)
  chore: apply wasmd v0.1.2 (Finschia#171)
  fix license copyright holder and typo (Finschia#170)
  Bump github.com/line/lbm-sdk from v0.47.0-rc4 to v0.47.0-rc4.0.20230410115856-b8421116b3f2 (Finschia#168)
  Bump up github.com/line/lbm-sdk from v0.47.0-rc3 to v0.47.0-rc4 (Finschia#167)
  chore: release v1.0.0-rc3 (Finschia#166)
  feat: bump up ibc-go v3.3.2 and wasmd for changing ibc light client of Ostracon to Tendermint (Finschia#164)
  chore: update license notice and code_of_conduct (Finschia#165)
  Bump github.com/line/lbm-sdk from v0.47.0-rc2 to v0.47.0-rc3 (Finschia#162)
  fix: fix `release-build` ci error occurred when adding assets after tagging (Finschia#163)
  chore: release v1.0.0-rc2 (Finschia#160)
  Bump github.com/line/lbm-sdk from v0.47.0-rc1 to v0.47.0-rc2 (Finschia#159)
  chore: update build args to arm64 (Finschia#157)
  ...
@zemyblue zemyblue mentioned this pull request Apr 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudong2 dudong2 dudong2 approved these changes

@zemyblue zemyblue zemyblue approved these changes

@tnasu tnasu Awaiting requested review from tnasu

@loloicci loloicci Awaiting requested review from loloicci

@ulbqb ulbqb Awaiting requested review from ulbqb

@torao torao Awaiting requested review from torao

@shiki-tak shiki-tak Awaiting requested review from shiki-tak

@tkxkd0159 tkxkd0159 Awaiting requested review from tkxkd0159

@da1suk8 da1suk8 Awaiting requested review from da1suk8

@Kynea0b Kynea0b Awaiting requested review from Kynea0b

@Mdaiki0730 Mdaiki0730 Awaiting requested review from Mdaiki0730

@loin3 loin3 Awaiting requested review from loin3

@jaeseung-bae jaeseung-bae Awaiting requested review from jaeseung-bae

Assignees

@0Tech 0Tech

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0Tech @zemyblue @dudong2