Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove x/token and x/collection apis in swagger #299

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Nov 3, 2023

Description

x/token and x/collection module are used in LBP internal service.
And they requested that is not displayed in swagger.

Motivation and context

How has this been tested?

  • make build
  • make install
  • ./init_single.sh
  • modify app.toml
    • [api] enable = true
    • [api] swagger = true
###############################################################################
###                           API Configuration                             ###
###############################################################################

[api]

# Enable defines if the API server should be enabled.
enable = true

# Swagger defines if swagger documentation should automatically be registered.
swagger = true

Screenshots (if appropriate):

스크린샷_2023-11-03_오후_2_16_50
This is a swagger snapshot that x/token and x/collection are removed

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #299 (4404cbc) into main (2070a67) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #299   +/-   ##
=======================================
  Coverage   49.16%   49.16%           
=======================================
  Files           9        9           
  Lines        1375     1375           
=======================================
  Hits          676      676           
  Misses        654      654           
  Partials       45       45           

@zemyblue zemyblue merged commit eeb4ff5 into Finschia:main Nov 3, 2023
38 checks passed
@zemyblue zemyblue deleted the feat/change_swagger branch November 3, 2023 05:50
mergify bot pushed a commit that referenced this pull request Nov 3, 2023
* chore: remove x/token and x/collection apis in swagger

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: udpate changelog

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
(cherry picked from commit eeb4ff5)

# Conflicts:
#	CHANGELOG.md
zemyblue added a commit that referenced this pull request Nov 3, 2023
#300)

* chore: remove x/token and x/collection apis in swagger (#299)

* chore: remove x/token and x/collection apis in swagger

Signed-off-by: zemyblue <zemyblue@gmail.com>

* chore: udpate changelog

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
(cherry picked from commit eeb4ff5)

# Conflicts:
#	CHANGELOG.md

* chore: resolve conflict and update changelog

Signed-off-by: zemyblue <zemyblue@gmail.com>

---------

Signed-off-by: zemyblue <zemyblue@gmail.com>
Co-authored-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue mentioned this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants