Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename namespace to v3 #329

Merged
merged 5 commits into from
Feb 28, 2024

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Feb 27, 2024

Description

  • Rename namespace to v3
  • change the upgradename to v3-Rose

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Signed-off-by: zemyblue <zemyblue@gmail.com>
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.16%. Comparing base (35dc203) to head (c4db428).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   49.16%   49.16%           
=======================================
  Files           9        9           
  Lines        1375     1375           
=======================================
  Hits          676      676           
  Misses        654      654           
  Partials       45       45           
Files Coverage Δ
app/app.go 83.30% <ø> (ø)
app/encoding.go 100.00% <ø> (ø)
cmd/fnsad/cmd/root.go 11.87% <ø> (ø)

ulbqb
ulbqb previously approved these changes Feb 27, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
170210
170210 previously approved these changes Feb 28, 2024
@da1suk8
Copy link
Member

da1suk8 commented Feb 28, 2024

@zemyblue

module github.com/Finschia/finschia/v2/interchaintest

Is there no need to make any changes to this?

tkxkd0159
tkxkd0159 previously approved these changes Feb 28, 2024
@zemyblue
Copy link
Member Author

@zemyblue

module github.com/Finschia/finschia/v2/interchaintest

Is there no need to make any changes to this?

Oh! it's a good point.
I think it needs to be modified also.
Thank you. I'll modify it.

Signed-off-by: zemyblue <zemyblue@gmail.com>
@zemyblue zemyblue dismissed stale reviews from tkxkd0159 and 170210 via c4db428 February 28, 2024 09:00
@zemyblue zemyblue merged commit 482c4be into Finschia:main Feb 28, 2024
42 checks passed
@zemyblue zemyblue deleted the feat/rename_namespace_v3 branch February 28, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants