Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Force user to follow the rule of release note generation #385

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

tkxkd0159
Copy link
Member

@tkxkd0159 tkxkd0159 commented May 28, 2024

Description

closes: #XXXX

  • Force user to write RELEASE_DESCR and CHANGELOG for all tags from now. We allowed to not write those sections sometimes and worked as best effort (getting latest previous content instead of exact previous tag content if we can't find). I decided to apply this rule to avoid confusion during release process.
  • small improvement - allowing version suffix in package path.

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

0Tech
0Tech previously approved these changes May 28, 2024
scripts/release-note.py Outdated Show resolved Hide resolved
@tkxkd0159 tkxkd0159 dismissed a stale review via 425df30 May 28, 2024 08:42
@Finschia Finschia deleted a comment from 0Tech May 28, 2024
@tkxkd0159 tkxkd0159 merged commit c62efc8 into main Jun 14, 2024
38 checks passed
@tkxkd0159 tkxkd0159 deleted the fix-release-script branch June 14, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants