(fixup) Improve coverage peer.go

Finschia · Jul 22, 2023 · 0d3fd6e · 0d3fd6e
1 parent 8cc8ef6
commit 0d3fd6e
Showing 1 changed file with 38 additions and 0 deletions.
diff --git a/p2p/peer_test.go b/p2p/peer_test.go
@@ -2,6 +2,7 @@ package p2p
 
 import (
 	"fmt"
+	"github.com/Finschia/ostracon/libs/service"
 	golog "log"
 	"net"
 	"testing"
@@ -22,6 +23,35 @@ import (
 	tmconn "github.com/Finschia/ostracon/p2p/conn"
 )
 
+// OldPeer does not implement EnvelopeSender(SendEnvelope/TrySendEnvelope)
+type OldPeer struct {
+	service.BaseService
+}
+
+func (mp *OldPeer) FlushStop()                        {}
+func (mp *OldPeer) TrySend(_ byte, _ []byte) bool     { return true }
+func (mp *OldPeer) Send(_ byte, _ []byte) bool        { return true }
+func (mp *OldPeer) NodeInfo() NodeInfo                { return DefaultNodeInfo{} }
+func (mp *OldPeer) Status() tmconn.ConnectionStatus   { return tmconn.ConnectionStatus{} }
+func (mp *OldPeer) ID() ID                            { return "" }
+func (mp *OldPeer) IsOutbound() bool                  { return true }
+func (mp *OldPeer) IsPersistent() bool                { return true }
+func (mp *OldPeer) Get(key string) interface{}        { return nil }
+func (mp *OldPeer) Set(key string, value interface{}) {}
+func (mp *OldPeer) RemoteIP() net.IP                  { return []byte{0} }
+func (mp *OldPeer) SocketAddr() *NetAddress           { return &NetAddress{} }
+func (mp *OldPeer) RemoteAddr() net.Addr              { return &net.TCPAddr{} }
+func (mp *OldPeer) CloseConn() error                  { return nil }
+func (mp *OldPeer) SetRemovalFailed()                 {}
+func (mp *OldPeer) GetRemovalFailed() bool            { return false }
+
+func TestSendWithOldPeer(t *testing.T) {
+	logger := log.TestingLogger()
+	p := &OldPeer{}
+	assert.True(t, SendEnvelopeShim(p, Envelope{ChannelID: testCh, Message: &p2p.Message{}}, logger))
+	assert.True(t, TrySendEnvelopeShim(p, Envelope{ChannelID: testCh, Message: &p2p.Message{}}, logger))
+}
+
 func TestPeerBasic(t *testing.T) {
 	assert, require := assert.New(t), require.New(t)
 
@@ -63,6 +93,10 @@ func TestPeerSend(t *testing.T) {
 	p, err := createOutboundPeerAndPerformHandshake(rp.Addr(), config, tmconn.DefaultMConnConfig())
 	require.Nil(err)
 
+	// False Test: isn't running peer
+	require.NoError(err)
+	require.False(SendEnvelopeShim(p, Envelope{ChannelID: testCh, Message: &p2p.Message{}}, p.Logger))
+
 	err = p.Start()
 	require.Nil(err)
 
@@ -74,6 +108,10 @@ func TestPeerSend(t *testing.T) {
 
 	assert.True(p.CanSend(testCh))
 	assert.True(SendEnvelopeShim(p, Envelope{ChannelID: testCh, Message: &p2p.Message{}}, p.Logger))
+
+	// False Test: hasn't channels
+	p.channels = []byte{}
+	require.False(SendEnvelopeShim(p, Envelope{ChannelID: testCh, Message: &p2p.Message{}}, p.Logger))
 }
 
 func createOutboundPeerAndPerformHandshake(