Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup develop environment of circleCI #42

Merged
merged 6 commits into from
Mar 25, 2020
Merged

Setup develop environment of circleCI #42

merged 6 commits into from
Mar 25, 2020

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Mar 24, 2020 •
edited
Loading

Add linting function.

  • linter checks only changes file of the branch of the Pull Request. (./scripts/current_branch_lint.sh)
  • You can use this linting using make lint or ./scripts/current_branch_lint.sh not only circleCI.

Checklist:

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@zemyblue zemyblue self-assigned this Mar 24, 2020
@zemyblue zemyblue changed the title [WIP] Setup develop environment of circleCI Setup develop environment of circleCI Mar 24, 2020
egonspace
egonspace approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@egonspace egonspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torao
torao approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@torao torao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@torao torao merged commit 55b8f34 into Finschia:develop Mar 25, 2020
@zemyblue zemyblue deleted the feature/setup_develop_environment branch April 7, 2020 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonspace egonspace egonspace approved these changes

@torao torao torao approved these changes

Assignees

@zemyblue zemyblue

Labels
None yet
Projects
None yet
Milestone
Evolve Leader Election into VRF
Development

Successfully merging this pull request may close these issues.
3 participants
@zemyblue @torao @egonspace