Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump github.com/stretchr/testify from 1.7.2 to 1.7.3 #436

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 20, 2022

Bumps github.com/stretchr/testify from 1.7.2 to 1.7.3.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.2 to 1.7.3.
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.7.2...v1.7.3)

---
updated-dependencies:
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jun 20, 2022
@torao torao self-assigned this Jun 21, 2022
@torao
Copy link
Contributor

torao commented Jun 21, 2022

Thank you for reporting, dependabot.

However, it seems to cause SEGV in our environment for the same reason as stretchr/testify#1206.

panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x4a490a]
goroutine 69 [running]:
testing.tRunner.func1.2({0x110d280, 0x19b3270})
	/opt/hostedtoolcache/go/1.18.3/x64/src/testing/testing.go:1389 +0x366
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.18.3/x64/src/testing/testing.go:1392 +0x5d2
panic({0x110d280, 0x19b3270})
	/opt/hostedtoolcache/go/1.18.3/x64/src/runtime/panic.go:844 +0x258
sync.(*Mutex).Lock(0x0)
	/opt/hostedtoolcache/go/1.18.3/x64/src/sync/mutex.go:74 +0x2a
github.com/stretchr/testify/mock.(*Mock).AssertExpectations(0xc000237cc0, {0x14923d8, 0xc000b471e0})
	/home/runner/go/pkg/mod/github.com/stretchr/testify@v1.7.3/mock/mock.go:511 +0xa9

mock/mock.go(511)

Fortunately, this PR is not urgent and a newer version 1.7.4 that fixes this issue has been released, so I'm thinking of skipping this version and waiting for a new version to be reported. @tnasu @kokeshiM0chi plz check (if there's a problem, it'll reopen).

@torao torao closed this Jun 21, 2022
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 21, 2022

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/go_modules/github.com/stretchr/testify-1.7.3 branch June 21, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant