-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix incompatible type of priv_validator_raddrs #767
Conversation
Signed-off-by: 170210 <j170210@icloud.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #767 +/- ##
==========================================
- Coverage 66.58% 66.54% -0.04%
==========================================
Files 285 285
Lines 37919 37914 -5
==========================================
- Hits 25248 25231 -17
- Misses 10871 10881 +10
- Partials 1800 1802 +2
|
Is it ok not to change parsing process although you change toml format? ostracon/privval/internal/ip_filter_test.go Lines 132 to 135 in ae67c39
ostracon/privval/internal/ip_filter.go Lines 29 to 31 in ae67c39
And old processes are left. |
ostracon/privval/internal/ip_filter.go Lines 29 to 31 in ae67c39
I checked currently main branch and #707, this function hasn't been used yet (only used in test), so I think we just need to delete it. |
Is it ok not to change parsing process although you change toml format? |
Description
This PR fix incompatible type of
priv_validator_raddrs
in TOMLThe
PrivValidatorRemoteAddresses
was defined as string array, while thepriv_validator_raddrs
was of a string type rather than a slice type, which creates a mismatch with the structure of the configuration after parsing the toml file.Related #692 & #707